[vlc-devel] [PATCH] bootstrap: run genmf in a subshell

[Rémi Denis-Courmont]

Le jeudi 21 janvier 2010 20:33:49 Francois Cartegnie, vous avez écrit :
> ---
>  bootstrap     |    2 +-
>  modules/genmf |    2 --
>  2 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/bootstrap b/bootstrap
> index 0334f46..51eb14a 100755
> --- a/bootstrap
> +++ b/bootstrap
> @@ -97,7 +97,7 @@ AC_DEFUN([PKG_CHECK_MODULES],[ifelse([\$4], , :, [\$4])])
>  EOF
>  fi
> 
> -sh modules/genmf `sed -ne 's,modules/\(.*\)/Makefile,\1,p' configure.ac`
> +( modules/genmf `sed -ne 's,modules/\(.*\)/Makefile,\1,p' configure.ac` )

sh is the POSIX shell. If there is a non-POSIX construct in genmf, it should 
be fixed. I still fail to see anything wrong with the current bootstrap.

> -#! /bin/sh
> -

No please. For instance, I want genmf run with dash (my /bin/sh), not with 
bash (my user shell).

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis