[vlc-devel] commit: Do not export unimplemented functions ( Rémi Denis-Courmont )

[Jean-Paul Saman]

On Sun, Jan 24, 2010 at 10:53 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On Sun, Jan 24, 2010 at 10:56:54AM +0100, git version control wrote :
>> Do not export unimplemented functions

How can I find out if there are teletext ES detected in vlc on libvlc
level? So that I can avoid using vlc_object_find_name(). ?

I need to know, so the functions can be implemented to match current
libvlccore implementation.

kind regards,
Jean-Pual Saman
>
>> -void libvlc_video_set_teletext( libvlc_media_player_t *p_mi, int i_page,
>> -                                libvlc_exception_t *p_e )
>> -{
>> -#if 0
>> -    vout_thread_t *p_vout = GetVout( p_mi, p_e );
>> -    vlc_object_t *p_vbi;
>> -    int i_ret = -1;
>> -
>> -    if( !p_vout ) return;
>> -
>> -    p_vbi = (vlc_object_t *) vlc_object_find_name( p_vout, "zvbi",
>> -                                                   FIND_CHILD );
>> -    if( p_vbi )
>> -    {
>> -        i_ret = var_SetInteger( p_vbi, "vbi-page", i_page );
>> -        vlc_object_release( p_vbi );
>> -        if( i_ret )
>> -            libvlc_exception_raise( p_e,
>> -                            "Unexpected error while setting teletext page" );
>> -    }
>> -    vlc_object_release( p_vout );
>> -#else
>> -    VLC_UNUSED( p_mi );
>> -    VLC_UNUSED( p_e );
>> -    VLC_UNUSED( i_page );
>> -#endif
>> -}
>> -
>>  void libvlc_toggle_teletext( libvlc_media_player_t *p_mi,
>>                               libvlc_exception_t *p_e )
>>  {
>> @@ -483,35 +428,6 @@ void libvlc_toggle_teletext( libvlc_media_player_t *p_mi,
>>          return;
>>      }
>>      const bool b_selected = var_GetInteger( p_input_thread, "teletext-es" ) >= 0;
>> -#if 0
>> -    int i_ret;
>> -    vlc_object_t *p_vbi;
>> -    p_vbi = (vlc_object_t *)vlc_object_find_name( p_input_thread, "zvbi",
>> -                                                  FIND_CHILD );
>> -    if( p_vbi )
>> -    {
>> -        if( b_selected )
>> -        {
>> -            /* FIXME Gni, why that ? */
>> -            i_ret = var_SetInteger( p_vbi, "vbi-page",
>> -                                    var_GetInteger( p_vbi, "vbi-page" ) );
>> -            if( i_ret )
>> -                libvlc_exception_raise( p_e,
>> -                                "Unexpected error while setting teletext page" );
>> -        }
>> -        else
>> -        {
>> -            /* FIXME Gni^2 */
>> -            i_ret = var_SetBool( p_vbi, "vbi-opaque",
>> -                                 !var_GetBool( p_vbi, "vbi-opaque" ) );
>> -            if( i_ret )
>> -                libvlc_exception_raise( p_e,
>> -                                "Unexpected error while setting teletext transparency" );
>> -        }
>> -        vlc_object_release( p_vbi );
>> -    }
>> -    else
>> -#endif
>
> Why where those functions commented at the beginning?
>
> Best Regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>