[vlc-devel] commit: New C++ binding for libvlc. ( R?mi Duraffort )
jb at videolan.org
Mon Jan 25 14:10:13 CET 2010
On Mon, Jan 25, 2010 at 12:58:18PM +0100, Pierre d'Herbemont wrote :
> On Jan 25, 2010, at 9:48, jpd at videolan.org wrote:
>> On Sat, Jan 23, 2010 at 05:10:36PM +0100, R?mi Duraffort wrote:
>>>> Awesome! I think you should drop the get prefix for the getters.
>>> MediaPlayer::time() for the getter
>>> MediaPlayer::setTime() for the setter ?
>> You don't even need a set prefix, overloading will take care of it:
>> mtime_t MediaPlayer::time();
>> void MediaPlayer::time(mtime_t);
> Please dont.
I agree with Pierre here.
>> I also think that the wrapper classes should inline (much) more
>> methods; now they're convenient but add entirely avoidable call
> I dont think it's actually a good idea. You save nothing, and makes
> headers unreadable. And it makes API even more a PITA.
I have mixed feeling on that. I don't see why it isn't a good idea,
except the headers readability.
More information about the vlc-devel