[vlc-devel] [PATCH] Fix-for-TS-Muxer-memory-leak (Part II)

Rafaël Carré rafael.carre at gmail.com
Mon Jan 25 16:21:28 CET 2010


On Mon, 25 Jan 2010 15:47:09 +0100
Jean-Paul Saman <jpsaman at gmail.com> wrote:

> On Sun, Jan 24, 2010 at 4:46 PM, Rafaël Carré
> <rafael.carre at gmail.com> wrote:
> > On Sat, 23 Jan 2010 21:51:40 -0500
> > Robert Krakora <rob.krakora at messagenetsystems.com> wrote:
> >
> >> The patch looks good.  I have had it running on over 100
> >> Linux-based mediaports since I came up with it in September and
> >> have seen no reoccurance of the memory leak.
> >
> > I can't review the patch but here some remarks made on irc:
> >
> > 19:37 < nefrir> mmh the code style is wrong (ie not consistant)
> > 19:37 < funman> also the for (i=-1...) looks weird
> > 19:39 < nefrir> and the patch protects only against audio missing I
> > think
> > 19:39 < nefrir> (his use case)
> > 19:40 < j-b> beurk at the patch then
> >
> > JPsaman could you have a look at it ?
> >
> 
> Which patch of the 2 is supposed to be the correct one?

They are the same patch, for the shorter one I used diff -w to remove
whitespace and indentation change.

-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100125/0595f29f/attachment.sig>


More information about the vlc-devel mailing list