[vlc-devel] commit: xcb: fix resizing failing to succeed sometimes (Erwan Tulou )

git version control git at videolan.org
Mon Jan 25 20:11:49 CET 2010

vlc | branch: master | Erwan Tulou <erwan10 at videolan.org> | Sun Jan 10 21:56:04 2010 +0100| [6862cff0c6951fd877ee5770135c83f88cbd2b0a] | committer: Erwan Tulou 

xcb: fix resizing failing to succeed sometimes

The vout window provider may issue a series of several resize events in a row.
(e.g a user switching back and forth between two layouts in skins2)
Some events may then be wrongly discarded by xcb based on a check that doesn't
represent the latest situation.
The new design actually can accept all resizing events, and only processes the last event of a series of events detected by xcb. No filtering is needed in xcb.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6862cff0c6951fd877ee5770135c83f88cbd2b0a

 modules/video_output/xcb/events.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/modules/video_output/xcb/events.c b/modules/video_output/xcb/events.c
index 9c70bd6..b12c013 100644
--- a/modules/video_output/xcb/events.c
+++ b/modules/video_output/xcb/events.c
@@ -165,9 +165,7 @@ static void
 HandleParentStructure (vout_display_t *vd,
                        const xcb_configure_notify_event_t *ev)
-    if (ev->width  != vd->cfg->display.width ||
-        ev->height != vd->cfg->display.height)
-        vout_display_SendEventDisplaySize (vd, ev->width, ev->height, vd->cfg->is_fullscreen);
+    vout_display_SendEventDisplaySize (vd, ev->width, ev->height, vd->cfg->is_fullscreen);

More information about the vlc-devel mailing list