[vlc-devel] commit: Qt: connect currentChanged signal from model earlier (Jakob Leben )

[Jakob Leben]

On Wed, Jan 27, 2010 at 2:41 PM, Ilkka Ollakka <ileoo at videolan.org> wrote:
>
> On Wed, Jan 27, 2010 at 02:27:42PM +0100, git version control wrote:
> > vlc | branch: master | Jakob Leben <jleben at videolan.org> | Wed Jan 27
> 12:49:48 2010 +0100| [4fdd32fab86f3d0a430ed6bc8394007c41d38b7b] | committer:
> Jakob Leben
>
> > Qt: connect currentChanged signal from model earlier
>
>
> Are you sure that connectin it that early is good idea? as currentView
> is NULL in that point and then handleExpansion triggers assert, if
> currentChanged happens before currentView is defined.
>


Well, the way we have it, all our slots are ever called in the same main Qt
application thread. That makes it impossible for the handleExpansion to be
called before the end of StandardPLPanel constructor.

Best regards
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100127/acb95db5/attachment.html>