[vlc-devel] commit: libvlc: Export libvlc_media_player_get_input_thread(). (Pierre d' Herbemont )

[Pierre d'Herbemont]

On Fri, Jan 29, 2010 at 1:00 PM, Rafaël Carré <rafael.carre at gmail.com> wrote:
> Le 29/01/10 12:49, Pierre d'Herbemont a écrit :
>> On Fri, Jan 29, 2010 at 12:36 PM, Rafaël Carré <rafael.carre at gmail.com> wrote:
>>> Le 29/01/10 11:49, git version control a écrit :
>>>> vlc | branch: master | Pierre d'Herbemont <pdherbemont at free.fr> | Fri Jan 29 01:42:55 2010 +0100| [714ef56a1682be404888668bd3c1c688cd0d2aeb] | committer: Pierre d'Herbemont
>>>>
>>>> libvlc: Export libvlc_media_player_get_input_thread().
>>>
>>>> + * Access to libvlc core internal structure.
>>>> + *
>>>> + * This enables nasty hack. Use of this method is discouraged.
>>>
>>> What kind of nasty hack ?
>>>
>>> How are you supposed to use / dereference the pointer?
>>
>> The kind of nasty hack where you link to libvlccore, and use the
>
> I hope this isn't Lunettes/Glasses

It is for VLCKit, so yes. This doesn't impact the rest.

>> input_thread directly. It's pretty much similar to
>> libvlc_get_vlc_instance().
>
> You could include internal headers in your project instead of adding 1
> crappy function to libvlc. That way the hack remains where it needs to be.

I did that for uniformity with libvlc_get_vlc_instance(). If you fix
it, you can fix this one.

Pierre.