[vlc-devel] commit: Do not export unimplemented functions ( Rémi Denis-Courmont )

[Laurent Aimar]

Hi,

On Wed, Jan 27, 2010, Jean-Paul Saman wrote:
> On Wed, Jan 27, 2010 at 11:44 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> >
> > On Tue, 26 Jan 2010 11:23:01 +0100, Jean-Paul Saman <jpsaman at gmail.com>
> > wrote:
> >> static vlc_object_t *get_marquee_object( libvlc_media_player_t * p_mi )
> >> {
> >>     libvlc_exception_t e;
> >>     libvlc_exception_init(&e);
> >>     vout_thread_t * vout = GetVout( p_mi, &e );
> >>     libvlc_exception_clear(&e);
> >>     if( !vout )
> >>         return NULL;
> >>     vlc_object_t * object = vlc_object_find_name( vout, "marq",
> > FIND_CHILD
> >> );
> >>     vlc_object_release(vout);
> >>     return object;
> >> }
> >
> > That code is buggy as hell, so I wouldn't take it as a reference. It fails
> > if there is more than one marquee, which is possible even with a single
> > video output. It also fails if the marquee filter is not yet fully
> > initialized - with no sane way to wait for it to be ready.
> >
> >> There is one other way to solve this by moving the variable 'vbi-page'
> >> in to vlc core. What is the recommended way?
> >
> > That's even worse. It would fail to account for multiple inputs.
> 
> So what is the excepted way of implementing this then? Is there a solution?
 I have added input_GetEsObjects that should allow to do it properly.

-- 
fenrir