[vlc-devel] [PATCH] support for stream size in imem access module

[Laurent Aimar]

Hi,

> @@ -170,6 +174,10 @@ vlc_module_begin()
>          change_private()
>          change_safe()
>  
> +    add_string ("imem-size", "0", NULL, SIZE_TEXT, SIZE_LONGTEXT, true) 
> +        change_private()
> +        change_safe()
> +

> @@ -316,6 +324,11 @@ static int OpenAccess(vlc_object_t *object)
>      access->pf_seek    = NULL;
>      access->p_sys      = (access_sys_t*)sys;
>  
> +    // we've got size as string, becouse we have no (u)int64_t var functions
> +    char * tmpsize = var_InheritString(object, "imem-size");
> +    access->info.i_size = strtoull(tmpsize, 0, 10);
> +    free(tmpsize);
 Your patch in itself is fine, but I wonder if we shouldn't add (u)int64
config support first. var_* does support int64_t using var_*Time, the only
bit missing seems to be config_* part.

 Anyone against config_ int64_t type support ? (If none, I will try to add it).

Regards,

-- 
fenrir