[vlc-devel] [PATCH 4/4] Adds the user interface to the compressor module

[Rémi Denis-Courmont]

On Thu,  1 Jul 2010 03:33:02 -0500, Ronald Wright
<logiconcepts819 at gmail.com> wrote:
> ---
>  modules/gui/qt4/components/extended_panels.cpp |  174
> ++++++++++++++++++++++++
>  modules/gui/qt4/components/extended_panels.hpp |   27 ++++
>  modules/gui/qt4/dialogs/extended.cpp           |    3 +
>  3 files changed, 204 insertions(+), 0 deletions(-)
> 
> diff --git a/modules/gui/qt4/components/extended_panels.cpp
> b/modules/gui/qt4/components/extended_panels.cpp
> index 874277a..bc3d661 100644
> --- a/modules/gui/qt4/components/extended_panels.cpp
> +++ b/modules/gui/qt4/components/extended_panels.cpp
> @@ -1117,6 +1117,180 @@ void Equalizer::addCallbacks( aout_instance_t
> *p_aout )
>   **********************************************************************/
> 
>  /**********************************************************************
> + * Dynamic range compressor
> + **********************************************************************/
> +static const char *psz_comp_control_names[] =
> +{
> +    "compressor-lo-pregain", "compressor-mid-pregain",
> "compressor-hi-pregain",
> +    "compressor-rms-peak", "compressor-attack", "compressor-release",
> +    "compressor-threshold", "compressor-ratio", "compressor-knee",
> +    "compressor-makeup-gain"
> +};

This lacks one level of const-ness. But I would rather have a arrays of
fixed-size arrays here - they're faster (at run-time) and smaller (on disk)
than arrays of pointers.

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis