[vlc-devel] [PATCH] fix a race condition in rtp stream output

[Sébastien Escudier]

Rémi,

On Thu, 2010-06-24 at 19:14 +0200, Sébastien Escudier wrote:
> On Thu, 2010-06-24 at 19:00 +0200, Rémi Denis-Courmont wrote:
> > 
> > I am not very happy with calling RtspAddId under lock_es, and I don't
> > understand why we would need to do that. 
> 
> The two patches are related.
> We can be in SDPGenerate and at the same time in SDPHandleUrl where I
> added the lock_es, and they both use p_sys->es[0].
> Without the lock, in my second patch there would be a race condition
> when I check (p_sys->es[0]->rtsp_id != NULL).


Do you still think it's not a good idea to lock lock_es when calling
RtspAddId, with this explanation ?