[vlc-devel] [PATCH] Allow on-the-fly multi-line marquee

[Johann Ransay]

On Tuesday 06 July 2010, Ilkka Ollakka wrote:
> On Tue, Jul 06, 2010 at 09:56:46AM +0200, Johann Ransay wrote:
> > Request for review. Thanks.
> > 
> > Johann
> > 
> > > @@ -598,6 +600,37 @@ static void Run( intf_thread_t *p_intf )
> > > 
> > >                  *psz_myarg = '\0';
> > >                  psz_myarg ++;
> > > 
> > > +                        /* move remaining characters one index
> > > backward */ +                        while( *(psz_subst+1) )
> > > +                        {
> > > +                            *psz_subst = *(psz_subst+1);
> > > +                            *psz_subst++;
> > > +                        }
> > > +                        *psz_subst = 0;
> 
> Shouldn't you compare against \0 and set last char as \0 instead of just
> 0 ?
Agreed.
> 
> > This e-mail, and any attachments, is intended only for use by the
> > addressee(s) named herein and may contain legally privileged and/or
> > confidential information belonging to Planar Systems, Inc.  If you are
> > not the intended recipient of this e-mail, you are hereby notified that
> > any dissemination, distribution or copying of this e-mail, any
> > attachments thereto, and use of the information contained, is strictly
> > prohibited.  If you have received this e-mail in error, please notify
> > the sender and permanently delete the original and any copy thereof.
> 
> I assume all vlc-devel recipients are intended recipients (including
> www-archives and all ) ?
Correct.

____________________________________________________________________
This e-mail, and any attachments, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information belonging to Planar Systems, Inc.  If you are not the intended recipient of this e-mail, you are hereby notified that any dissemination, distribution or copying of this e-mail, any attachments thereto, and use of the information contained, is strictly prohibited.  If you have received this e-mail in error, please notify the sender and permanently delete the original and any copy thereof.
______________________________________________________________________