[vlc-devel] [PATCH] Allow on-the-fly multi-line marquee

[Johann Ransay]

First, thanks for your time in reviewing this patch.

- the patch changes the behaviour of the oldrc intf module, not a command line 
parameter
- it affects the way the marquee is drawn on top of the video, not the 
behaviour of any external script
- there is no way for this patch to explode on any script: for a text 
containing '\\' 'n' the oldrc module would draw "backslash n" (no 
substitution) where the new behaviour would draw a newline instead.
- the marquee filter already supports newlines in the marquee but prior to this 
patch a newline could not be inserted from the oldrc module which, IMHO, is a 
bug.

Just in case, I've attached the modified patch taking into account the remarks 
from Ilkka Ollakka.

Regards,
Johann

On Tuesday 06 July 2010, Rémi Denis-Courmont wrote:
> On Tue, 6 Jul 2010 09:56:46 +0200, Johann Ransay <johann.ransay at planar.com>
> 
> wrote:
> > Request for review. Thanks.
> 
> I am not very keen on silently changing the syntax of a parameter. I expect
> a number of people have scripted the marquee filter such that your patch
> will explode on them.


____________________________________________________________________
This e-mail, and any attachments, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information belonging to Planar Systems, Inc.  If you are not the intended recipient of this e-mail, you are hereby notified that any dissemination, distribution or copying of this e-mail, any attachments thereto, and use of the information contained, is strictly prohibited.  If you have received this e-mail in error, please notify the sender and permanently delete the original and any copy thereof.
______________________________________________________________________

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Allow-on-the-fly-multi-line-marquee.patch
Type: text/x-patch
Size: 2513 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100706/2075fb26/attachment.bin>