[vlc-devel] [PATCH] statistics for libvlc

Ilkka Ollakka ileoo at videolan.org
Wed Jul 14 19:13:59 CEST 2010


On Wed, Jul 14, 2010 at 06:04:41PM +0200, Frank Enderle wrote:
> i see. i didn't know that there's such a function. do you think it would
> be a better idea to return the stats structure directly without copying?
> - i wanted to hide the mutex from the user, but maybe this is not
> necessary at all?

stats_ComputeInputStats sets values to given p_stat structure.
NewInputStats() resets stats to 0, so I don't think it should be used in
this case. ComputeInputStats needs input_stats_t * as second parameter,
but what I quickly looked you made libvlc_statistics_t same structure as
input_stats_t so it should be problem.

-- 
Ilkka Ollakka
When Marriage is Outlawed,
Only Outlaws will have Inlaws.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100714/b4649df8/attachment.sig>


More information about the vlc-devel mailing list