[vlc-devel] [vlc-commits] commit: input: Fill in the input_item es. (Pierre d'Herbemont )

[Pierre d'Herbemont]

On Wed, Jul 14, 2010 at 8:57 PM, Laurent Aimar <fenrir at elivagar.org> wrote:
> Hi,
>
> On Wed, Jul 14, 2010 at 08:41:53PM +0200, git at videolan.org wrote:
>> vlc/vlc-1.1 | branch: master | Pierre d'Herbemont <pdherbemont at free.fr> | Mon Feb 22 17:20:27 2010 +0100| [91d9a74630aa4ff9baaca6830887fd39c1141277] | committer: Pierre d'Herbemont
>  -----------
>
>>  struct input_item_t
>>  {
>>      VLC_GC_MEMBERS
>> @@ -73,6 +102,9 @@ struct input_item_t
>>      int         i_es;                /**< Number of es format descriptions */
>>      es_format_t **es;                /**< Es formats */
>>
>> +    int i_tracks;                    /**< Number of track info descriptions */
>> +    input_item_track_t **tracks;     /**< Tracks Info */
>> +
>  This breaks the ABI and so I don't think it can be accepted in vlc 1.1 branch.

Yes, that's a mistake. I wanted to push this patch that we had pre-vlc
1.1 release in master before it went completely forgotten.

>  Anyway, if you really want 'tracks' to be usefull, I don't think that you can really
> cut down a lot of field from es_format_t, and so you could probably simply use the
> already present 'es' field (for master and 1.1, and it will avoid the ABI breakage)...

I don't think we need this for 1.1, because it breaks also libvlc
documented behaviour. That said I don't remember why I didn't reuse
the es field, and it seems to make sense.

Pierre.