[vlc-devel] [PATCH] fix build with taglib 1.6

Rémi Duraffort ivoire at videolan.org
Thu Jul 15 19:35:36 CEST 2010


> > I wonder if this should not be a taglib version check rather than a manual
> > header check?
> Hi,
> 
> this could be done with pkg-config, however, I have taglib 1.6.2 in
> Mandriva 2010.1 and the pkgconfig file contains version: 1.6.1.
I think we will go on with the header check as:
 * taglib.pc declare version 1.6 for taglib versions 1.6.(0,1,2) (only
the latest one declare the right version)
 * I found TAGLIB_MAJOR_VERSION, TAGLIB_MINOR_VERSION and
TAGLIB_PATCH_VERSION in taglib.h but the are identical in 1.6.(0,1,2)
releases (only the latest one is correct).

So I guess the right way is to add a test based on the header (I will do
it as the patch was not completelly correct)

-- 
Rémi Duraffort | ivoire



More information about the vlc-devel mailing list