[vlc-devel] [PATCH] Integrate the RTMPdump library to play rtmp and rtmpe streams.

[Daniel Tisza]

Hi,

Thanks for the comments.
Attached two new independent patches.
I reworked freeing on failures in the opening phase.

Concerning the changes suggested by Jean-Baptiste Kempf:

> You can use for ( unsigned int i = 0 ; ....
Changed to that.

> VLC_ENOMEM maybe?
Changed to that.

Concerning the following by Rémi Denis-Courmont

> I still don't understand why this requires a new Makefile directory and three
> separate source code files. I am all for keeping files small, but...

I created and attached now two patches to choose from.

PATCH 1:
This is with rtmpdump in a subdirectory as so far.

PATCH 2:
This is with only a single modules/access/rtmpdump.c file.

> And then, it seems that the rtmpdump is mindboggingly broken by design as it
> uses white spaces in URL. I doubt that can work inside VLC.

I'm not entirely sure if I understand the main issue here.
These are the points in my view at the moment:

1. For a successful connection to an RTMP server two things are required:
    a) rtmp url
    b) rtmp connection parameters
(Sometimes you get away with no parameters, but more often not).

2. librtmp used to have different parameters in data structures, which
were passed to a setup function.

3. librtmp is now using a setup string, which is the rtmp url + params.
The setup string is the recommended approach by Howard Chu.
However, we can compose this setup string ourselves from the MRL and
vlc options as I have done.
Please see the detailed comparison below.

----

Now, VLC has (at least) two scenarios to give access to librtmp.

1. User enters the rtmp url as the MRL and rtmp params as vlc options
(rtmp-*=xyzzy).
This never ever needs spaces anywhere in VLC.
The spaced 'url' is made only for setting up librtmp and is composed
automatically from the MRL and the options.
This solution I have posted now.

2. User enters as MRL the whole string passed to librtmp, meaning rtmp
url + params.
This is not possible now, because the user interface doesn't allow spaces.
This solution I have never posted as a patch.

Here is a link to Howard Chu's comments on the parameter passing:
http://comments.gmane.org/gmane.comp.video.ffmpeg.devel/108419

----

Regards,
Daniel Tisza
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtmpdump7.patch
Type: text/x-patch
Size: 22772 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100718/61abfed1/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtmpdump8.patch
Type: text/x-patch
Size: 15709 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100718/61abfed1/attachment-0001.bin>