[vlc-devel] Support for Clear QAM also improved BDA under Windows 7

[Manol Manolov]

I send the first patch again (unchanged). Also add GUI option.


Silent cast to long -> in my case integer is sufficient but the API function
accepts long. The frequency won't exceed 999999 (KHz).
I just use the same method as the rest of the code to keep it easier to
read.


The MRL is cqam://:frequency=xxxx 
The rest of the options are useless like "program-number" because VLC demux
is used instead the MS demux and the bda setting cannot be applied. The
"--program" option can be used instead, which controls the VLC demux.


I added GUI option as you suggested.



-----Original Message-----
From: vlc-devel-bounces at videolan.org [mailto:vlc-devel-bounces at videolan.org]
On Behalf Of Jean-Baptiste Kempf
Sent: Sunday, July 18, 2010 5:10 AM
To: Mailing list for VLC media player developers
Subject: Re: [vlc-devel] Support for Clear QAM also improved BDA under
Windows 7

On Sat, Jul 17, 2010 at 11:23:54PM -0400, Manol Manolov wrote :
> This is my first patch, so please tell me if I do something wrong.

var_GetInteger returns int64, IIRC, and you are silently casting them to
long (int32 on Win*). Normal?

Else, it looks pretty fine if tested.

> Add  US cable HD television support. I believe it will work only on Win 7.

Cool, do you have a MRL to play this back?

> Preserved the old functionality of BDA, also made it to work under Win 7.
Can you detail?

Should we adapt the UI too ?

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
http://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-GUI-support-for-Clear-QAM.patch
Type: application/octet-stream
Size: 3020 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100718/fe5b1127/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-support-for-Clear-QAM.patch
Type: application/octet-stream
Size: 12985 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100718/fe5b1127/attachment-0001.obj>