[vlc-devel] [vlc-commits] commit: Configure: don't stop everything when modplug 0.8.8 is detected, just deactivate the module (Jean-Baptiste Kempf )

[Rémi Denis-Courmont]

Le dimanche 18 juillet 2010 19:39:25 git at videolan.org, vous avez écrit :
> vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Sun Jul 18
> 18:28:19 2010 +0200| [a9d916728b2717206a0a7fe0702b0bc6dad16747] |
> committer: Jean-Baptiste Kempf
> 
> Configure: don't stop everything when modplug 0.8.8 is detected, just
> deactivate the module
> 
> This was annoying because if you had a modplug.pc and didn't --enable-mod,
> it was auto-detected and then failed.

So? If you have libmodplug installed you expect it to work with VLC like it's 
always done. Hence an explicit --disable-mod is The Right Thing to bypass the 
configure failure.

Not to mention, that now even if --enable-mod is given, configure happily 
disables and goes forward, which is unarguably wrong.

This commit sucks big time IMHO.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis