[vlc-devel] [PATCH 2/8] Do not link to ole32 when trying to build Qt4 module on OSX

[Juho Vähä-Herttua]

21.7.2010 17:04, Jean-Baptiste Kempf kirjoitti:
> On Wed, Jul 21, 2010 at 04:54:20PM +0300, Juho Vähä-Herttua wrote :
>    
>>   configure.ac |    9 +++++++--
>>      
> Seems ok, maybe it should be the reverse: ie, -lole32 only on Win32.
>    

Actually I just remembered there was already discussion about this patch 
earlier, but I didn't change it back then. The code right before it goes:

     AS_IF([test "${SYS}" != "mingw32" -a "${SYS}" != "mingwce" -a 
"${SYS}" != "darwin"], [
         VLC_ADD_LIBS([qt4],[$QT4_LIBS ${X_LIBS} ${X_PRE_LIBS} -lX11])
         need_xid_provider="no"
         VLC_ADD_CXXFLAGS([qt4],[$QT4_CFLAGS ${X_CFLAGS}])
     ], [
         AS_IF([test "${SYS}" != "darwin"], [
             VLC_ADD_LIBS([qt4],[$QT4_LIBS -lole32])
             VLC_ADD_CXXFLAGS([qt4],[$QT4_CFLAGS])
         ], [
             VLC_ADD_LIBS([qt4],[$QT4_LIBS])
             VLC_ADD_CXXFLAGS([qt4],[$QT4_CFLAGS])
         ])
     ])

So I simply followed the convention used earlier to avoid any logical 
mistakes. I'm ok with changing it though.


Juho