[vlc-devel] [PATCH 4/8] qt4: Remove the __STDC_ISO_10646__ ifdef , it's not found on win32 or osx

Rémi Denis-Courmont remi at remlab.net
Wed Jul 21 17:13:26 CEST 2010

Le mercredi 21 juillet 2010 17:13:40 Juho Vähä-Herttua, vous avez écrit :
> 21.7.2010 17:08, Jean-Baptiste Kempf kirjoitti:
> > There is a reason why this is the case, IIRC, so || defined( __APPLE__ )
> > 
> >    might be better.
> I did the patch, because I'd like to know the actual reason. What I'm
> guessing is that the function might work differently on some platforms
> than others and the define is making sure it is working correctly.

The behaviour of tolower() is not fully specified by the C standard. If 
ISO_10646 (i.e. Unicode) is not explicitly supported, we don't know *a priori* 
what towlower() does, especially on non-ASCII characters.

Rémi Denis-Courmont

More information about the vlc-devel mailing list