[vlc-devel] [PATCH 6/8] osx: Remove -arch from CPPFLAGS, it is not needed and gets passed to moc on Qt4

[Pierre d'Herbemont]

On Wed, Jul 21, 2010 at 6:55 PM, Juho Vähä-Herttua <juhovh at iki.fi> wrote:
> On 21.7.2010, at 18.25, Rémi Denis-Courmont wrote:
>> Le mercredi 21 juillet 2010 17:25:01 Juho Vähä-Herttua, vous avez écrit :
>>> 21.7.2010 17:17, Jean-Baptiste Kempf kirjoitti:
>>>> On Wed, Jul 21, 2010 at 04:54:24PM +0300, Juho Vähä-Herttua wrote :
>>>>>  configure.ac |    1 -
>>>>
>>>> hmmm, ok. Are you sure it isn't needed for PPC ?
>>>
>>> CPPFLAGS are for preprocessing and -arch is useful for compiling and
>>> linking (it affects the binary output of compiler), I very much doubt it
>>> is needed there. If it is however, I think someone is using CPPFLAGS
>>> incorrectly...
>>
>> Uh no. The archictecture affects some predefined macros (in GCC at least).
>
> I checked that the __powerpc__ that it apparently affects is used in VLC and therefore that patch is not ok.

Yes, you have the same issue with __x86_64__ and __i386__.

Pierre.