[vlc-devel] [PATCH] Direct2D video output module

David Kaplan david at 2of1.org
Thu Jul 22 17:02:37 CEST 2010

On Thu, Jul 22, 2010 at 5:51 PM, Geoffroy Couprie <geo.couprie at gmail.com>wrote:

> +            msg_Err(vd, "Cannot create Direct2D factory (hr = 0x%x)!",
>> +                (uint32_t)hr);
> Could you make a more explicit error message? Or don't display the hresult
> in a msg_Err, but in a msg_Dbg.

Well it's hard to make more explicit without parsing HRESULT vals (and
there's no point in doing this).
I can convert to msg_Dbg() but I thought msg_Err() would make more sense
because it's a complete fail?
Please advise...

> How is the calling function handling the case where a render target could
> not be created? Is it crashing? Is it throwing an error because it can't
> write to the render target?

It goes to 'error:' which cleans up and returns VLC_EGENERIC
But I notice that I'm not handling a failure of D2D_CreateRenderTarget() at
all. This I'll fix.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100722/1261523e/attachment.html>

More information about the vlc-devel mailing list