[vlc-devel] [PATCH 5/6] qt4: Run mainloop on the main thread on OSX

[Rémi Denis-Courmont]

Le dimanche 25 juillet 2010 12:27:01 Juho Vähä-Herttua, vous avez écrit :
> On 25.7.2010, at 10.07, Rémi Denis-Courmont wrote:
> > Le dimanche 25 juillet 2010 00:48:28 Juho Vähä-Herttua, vous avez écrit :
> >>> That thread looks quite useless.
> >> 
> >> It looks quite useless, but I plan to use it to start the playlist in
> >> the middle of those two sem_wait calls.
> > 
> > You might as well do that after vlc_sem_post() directly. That's one line
> > of code (plus two lines of ifdef).
> 
> Could you give your comments on this one? It's basically the one I sent
> earlier, but makes sure that the semaphore is downed to zero before
> thread_join on non-OSX as well, and it starts the playlist on OSX.
> Actually I'm already quite happy with it, now that I can start the video
> on Qt4 interface by just adding it on command line. It adds just 7 lines
> of code and moves the vlc_sem_destroy to Close instead of Open.

Looks a bit better. But would things not be an order of magnitude simpler if 
you did not use b_run_on_first_thread. Why can't you replace:

	vlc_clone(Thread);

with

#if !MAC
	vlc_clone(Thread, p_intf);
#else
	Thread(p_intf);
#endif

and ignore pf_run as well?

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis