[vlc-devel] [PATCH] Direct2D video output module

[Rémi Denis-Courmont]

On Wed, 28 Jul 2010 06:28:14 +0300, David Kaplan <david at 2of1.org> wrote:
> On Wed, Jul 28, 2010 at 12:37 AM, Laurent Aimar <fenrir at elivagar.org>
> wrote:
>>
>>  I have tested it and it works well (including zoom/ar/autoscale/crop).
>>
> Thanks as always! :)
> 
> 
>> > +    vd->fmt.i_chroma = VLC_CODEC_RGB32; /* masks change this to BGR32
>> for ID2D1Bitmap */
>> > +    vd->fmt.i_rmask  = 0x000000ff;
>> > +    vd->fmt.i_gmask  = 0x0000ff00;
>> > +    vd->fmt.i_bmask  = 0x00000000;
>>  Can't 0x00ff0000 works (now that you don't use RGBA)?
> 
> 
> Still broken with RGB32 and RGBA so this is still necessary.

Note that VLC_CODEC_RGBA does not implement RGB masks currently. It is
always R-G-B-A as the name implies. And frankly, I prefer it that way - I
find that much easier to deal with in most cases. We should probably add a
separate VLC_CODEC_ARGB codec.

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis