[vlc-devel] [PATCH] Direct2D video output module

Rémi Denis-Courmont remi at remlab.net
Wed Jul 28 09:41:06 CEST 2010




On Wed, 28 Jul 2010 10:04:44 +0300, David Kaplan <david at 2of1.org> wrote:
> 2010/7/28 Rémi Denis-Courmont <remi at remlab.net>
> 
>>
>> Note that VLC_CODEC_RGBA does not implement RGB masks currently. It is
>> always R-G-B-A as the name implies. And frankly, I prefer it that way -
> I
>> find that much easier to deal with in most cases. We should probably add
> a
>> separate VLC_CODEC_ARGB codec.
>>
>>
> But then VLC would need a version for each combination: BGR, RGB, etc.
> etc.?

In practice, you need to handle each cases anyway, especially when writing
heavy optimizations.

I don't know how many combinations are really used for RV24 and RV32.
Somehow, I doubt all 6 possible combinations of RV24, and 12 combinations
of RV32 are useful. For alpha-mask RGB, I have only ever seen ARGB and
RGBA. Even if we took mismatched endianess into account, 4 different codecs
seems much more reasonable than 24 different bit masks combinations.

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis




More information about the vlc-devel mailing list