[vlc-devel] [PATCH] Direct2D video output module

[Laurent Aimar]

On Wed, Jul 28, 2010 at 08:38:55AM +0200, Rémi Denis-Courmont wrote:
> 
> On Wed, 28 Jul 2010 06:28:14 +0300, David Kaplan <david at 2of1.org> wrote:
> > On Wed, Jul 28, 2010 at 12:37 AM, Laurent Aimar <fenrir at elivagar.org>
> > wrote:
> >>
> >>  I have tested it and it works well (including zoom/ar/autoscale/crop).
> >>
> > Thanks as always! :)
> > 
> > 
> >> > +    vd->fmt.i_chroma = VLC_CODEC_RGB32; /* masks change this to BGR32
> >> for ID2D1Bitmap */
> >> > +    vd->fmt.i_rmask  = 0x000000ff;
> >> > +    vd->fmt.i_gmask  = 0x0000ff00;
> >> > +    vd->fmt.i_bmask  = 0x00000000;
> >>  Can't 0x00ff0000 works (now that you don't use RGBA)?
> > 
> > 
> > Still broken with RGB32 and RGBA so this is still necessary.
> 
> Note that VLC_CODEC_RGBA does not implement RGB masks currently.
 Yes but rgb masks and VLC_CODEC_RGB32 should work. Setting one of the mask to
zero force the core to redefine all of the masks (except for RGBA), and so
defining them here should work (it is done for glwin32 for example). Not sure
what is the exact issue, I will have to test.

-- 
fenrir