[vlc-devel] [vlc-commits] commit: Qt: Fix save volume on exit Fixes #2968 (Francois Cartegnie )

[Rémi Denis-Courmont]

Le mercredi 28 juillet 2010 22:29:10 Laurent Aimar, vous avez écrit :
> Hi,
> 
> On Wed, Jul 28, 2010 at 08:06:38PM +0200, git at videolan.org wrote:
> > vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Fri Mar  5
> > 19:42:42 2010 +0100| [989ec97aa4b0034e6a4599df11ba5301e5b42af2] |
> > committer: Francois Cartegnie
> > 
> > Qt: Fix save volume on exit Fixes #2968
> > +    config_PutInt( p_intf, "volume", i_volume );
> > +    config_SaveConfigFile( p_intf, NULL );
> 
>  I thought that this kind of config_SaveConfigFile uses was not ok. Can
> anyone comment on it?

It is harmful indeed.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis