[vlc-devel] [vlc-commits] commit: Qt: save volume on exit ( Francois Cartegnie )

[Rémi Denis-Courmont]

Le vendredi 30 juillet 2010 00:39:34 Francois Cartegnie, vous avez écrit :
> Le jeudi 29 juillet 2010, vous avez écrit :
> > There is a reason why the preferences dialog has separate OK and Save
> > 
> >  buttons. Your stupid change made the configuration ALWAYS saved at exit.
> >  This is wrong and unacceptable. This is _not_ going to change just for
> >  the sake of the audio volume.
> 
> Yep, that was out of my scope and stupid but that was config_save related
> and not the last commit.

It should be obvious to anyone writing VLC code that you can't change random 
data shared by multiple threads.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis