[vlc-devel] [vlc-commits] commit: Qt: save volume on exit ( Francois Cartegnie )

Rémi Denis-Courmont remi at remlab.net
Fri Jul 30 17:43:39 CEST 2010

----- Message d'origine -----
> Le vendredi 30 juillet 2010, vous avez écrit :
> >
> > It should be obvious to anyone writing VLC code that you can't change
> >  random data shared by multiple threads.
> I picked config_SaveConfigFile because it is the code associated to the "Save"

Uh? The question was about the b_autosave revert. So was the answer.

> button. I don't why the user choice would provide better thread safe guarantee
> doing a config_SaveConfigFile though the prefs window at time T, and saving
> the same variables at time T+1. If it's prefs variables, it should still be
> untouched.

That would be thread-safe. That is just functionaly wrong and caused a number of bugs and user confusion in the past.

More information about the vlc-devel mailing list