[vlc-devel] [PATCH 2/3] Add an abort function to the Mac interface hack, remove extra thread

[Juho Vähä-Herttua]

On 31.7.2010, at 19.57, Rémi Denis-Courmont wrote:
> Le samedi 31 juillet 2010 18:47:32 Juho Vähä-Herttua, vous avez écrit :
>> +            libvlc_SetExitHandler( p_intf->p_libvlc,
>> +                                   (void (*) (void *)) p_intf->pf_abort,
>> +                                   (void *) p_intf );
> 
> This is really no better than calling libvlc_SetExitHandler() directly in the 
> interface. It's just more complicated. The limitations are the same either 
> (which is to say, libvlc_add_intf() and libvlc_set_exit_handler() will break, 
> but there's no way around that).

Mainly including "../../../src/control/libvlc_internal.h" just didn't sound right, and I wanted to keep the code calling it in the core so that it can be easily located in case of problems. But if that's the case, then I'll just merge the two mac patches into one uglier but less complicated one, which is your point I hope.

I still need some way to make sure the Thread function has finished execution before I cleanup in the Close since thread_join won't work, so I'll wait for your reply on how it should be done without using the semaphore. 


Juho

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4215 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100731/c6018fea/attachment.bin>