[vlc-devel] [PATCH] Merge VoD module into RTP stream output module

[Rémi Denis-Courmont]

Le jeudi 3 juin 2010 08:27:32 Pierre Ynard, vous avez écrit :
> It currently does so by walking up the object tree from the RTP sout to
> the VoD object. I used to use a simple vlc_object_find(INPUT, PARENT)
> (which was pretty safe since the VoD core doesn't use sout-keep, if
> I understand the situation correctly), but this was recently broken.
> Once this is figured out, I can properly rewrite this part. Or, an
> alternative approach would be to pass a pointer to the vod_media_t in
> the #rtp stream output chain, but this is a little ugly too (though it
> would save a lock). Opinions?

I would rather not pass a pointer in the chain. Stringifying pointers confuses 
valgrind, and allows users to shoot themselves in the foot. Admittedly, we do 
it in some cases anyway, mostly for LibVLC needs.

But in this case, you can probably simply create a pointer variable and 
inherit it in the RTP stream output. You will probably need the attached patch 
for the non-VoD case.

Synchronization will be "interesting" though.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch
Type: text/x-patch
Size: 522 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100603/ea75b4fc/attachment.bin>