[vlc-devel] Bug fix to http interface in VLC

Christian cmasus at kth.se
Sat Jun 5 11:59:24 CEST 2010


Hi

Could someone please commit the following bug fix to VLC.

There has been a bug for a while in the standard VLC http interface. As I
understand it VLC_OBJECT_VLC was replaced with VLC_OBJECT_LIBVLC. But that
change wasn't made for the http interface.
So, can someone please commit a change on the file [dir to
vlc]/http/requests/status.xml

Here is the diff between the old and the fixed version:

diff status.xml status.xml.old
104c104
<     <vlc id="rpn" param1="'key-' val value strcat vlc_config_get
key-pressed 'VLC_OBJECT_LIBVLC' vlc_var_set" />
---
>     <vlc id="rpn" param1="'key-' val value strcat 'VLC_OBJECT_VLC'  
> vlc_var_get key-pressed 'VLC_OBJECT_VLC' vlc_var_set" />


And with context output format:

diff -c status.xml status.xml.old
*** status.xml	2010-05-25 19:20:06.098078705 +0200
--- status.xml.old	2010-05-25 19:18:41.440079120 +0200
***************
*** 101,107 ****
           <vlc id="rpn" param1="val value vlc_seek" />
         <vlc id="end"/>
         <vlc id="if" param1="command value 'key' strcmp 0 =" />
!     <vlc id="rpn" param1="'key-' val value strcat vlc_config_get
key-pressed 'VLC_OBJECT_LIBVLC' vlc_var_set" />
         <vlc id="end"/>

       <vlc id="end" />
--- 101,107 ----
           <vlc id="rpn" param1="val value vlc_seek" />
         <vlc id="end"/>
         <vlc id="if" param1="command value 'key' strcmp 0 =" />
!     <vlc id="rpn" param1="'key-' val value strcat 'VLC_OBJECT_VLC'
vlc_var_get key-pressed 'VLC_OBJECT_VLC' vlc_var_set" />
         <vlc id="end"/>

       <vlc id="end" />


I am developing a remote for VLC using this interface. So I would like this
functionality to be available to everyone.

Can someone please commit this change? I have tested the change in both
linux and windows and it works fine. Can someone also confirm to me that
this change has been committed, so that I know that it will be available
in the next VLC version (I guess the next one will be 1.0.7).


Thanks for the great work with the worlds best media player :).

Best regards
/Christian



More information about the vlc-devel mailing list