[vlc-devel] Updated patch for ogg/theora seeking

[salsaman]

http://lives.sourceforge.net
https://www.ohloh.net/accounts/salsaman



On Mon, Jun 7, 2010 at 5:13 PM, salsaman <salsaman at gmail.com> wrote:

>
>
>
> On Mon, Jun 7, 2010 at 5:10 PM, salsaman <salsaman at gmail.com> wrote:
>
>>
>>
>> On Mon, Jun 7, 2010 at 4:42 PM, Jean-Baptiste Kempf <jb at videolan.org>wrote:
>>
>>> On Mon, Jun 07, 2010 at 08:59:08AM -0300, salsaman wrote :
>>> > diff --git a/modules/codec/theora.c b/modules/codec/theora.c
>>>
>>> > +    /* need to skip some pages after a seek */
>>> > +    if ( p_block->i_flags & BLOCK_FLAG_PREROLL )
>>> > +        {
>>> > +            p_sys->b_skip_frame = true;
>>> > +    }
>>> > +    else p_sys->b_skip_frame = false;
>>> Wouldn't something like this, be better?
>>> p_sys->b_skip_frame = ( p_block->i_flags & BLOCK_FLAG_PREROLL );
>>>
>>>
>>>
>>
>
>
>
>
>
>>
>> Yes, you are right. I will change it.
>>
>>
>
> Actually, come to think of it, no, strictly speaking:
>
> e.g.
>
> BLOCK_FLAG_PREROLL = 2
>
> p_block->i_flags = 2
>
> p_block->i_flags&BLOCK_FLAG_PREROLL = 2;
>
> true = 1;
>
> Ooops !!
>
>
> Gabriel.
>
>

or in other words, boolean should be constrained to only take the values
true or false.


Gabriel.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100607/6a35e7ff/attachment.html>