[vlc-devel] [PATCH] dvbsub.c : Don't fill region if page_state == 0

[Ilkka Ollakka]

On Tue, Jun 08, 2010 at 08:37:13PM +0200, Björn Stenberg wrote:
> Hi.

> I've been working a little with DVB subtitling and found that if the
> region_fill bit is set, vlc always fills the whole area on every
> region update and thus overwrites any data previously rendered. This
> behaviour breaks "live" subtitling where words are recieved one at a
> time and added to an existing region.

Hi,

Would it be possible you to provide some test clip on that?

> My interpretation of ETSI EN 300 743 is that the region_fill_flag of a
> region composition segment should not cause the region to be filled
> when the containing page composition segment has its' page_state
> variable set to 0 (page update).

Maybe Meuuh/jpsaman/* can comment on this one, I don't have a clue

> I suggest something like this:

Please provide patch that applies and is against git-tree:
http://wiki.videolan.org/Git#Submitting_patches_to_the_vlc-devel_or_x264-devel
that would make applying patches much easier and faster.

-- 
Ilkka Ollakka
Garbage In -- Gospel Out.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100609/d96c029e/attachment.sig>