[vlc-devel] [PATCH] Ignore unmute if volume hasn't been set or muted. fixes #3636

Francois Cartegnie fcvlcdev at free.fr
Wed Jun 9 15:06:53 CEST 2010


Le mercredi 9 juin 2010, Rémi Denis-Courmont a écrit :
> However, several developers objected to the complexity of doVolumeChanges
> (to me, as I merged it). And I admit I do not fully grasp it myself anymore
> either. I am not sure that merging everything in one function with plenty
> of parameters was such a great idea. Oh well, too late for 1.1 anyway.

As we needed to introduce a 'mixer' lock level, not centralizing the changes 
would have resulted in locks spread in too many functions and a big headache.

Francois



More information about the vlc-devel mailing list