[vlc-devel] [PATCH] support for size in immem + fixed typo

Christophe Mutricy xtophe at chewa.net
Thu Jun 10 00:53:07 CEST 2010


Some nit-picking comments

> +    add_string ("imem-size", "0", NULL, SIZE_TEXT, SIZE_LONGTEXT, true) 
> +        change_private()
> +		change_safe()
> +

Why  is change_safe more indented than change_private .

>  /*****************************************************************************
> - * Local prototypes
> + * Local prototypes	
>   *****************************************************************************/
>  

White char changes should go in another commits

>  /* */
> @@ -307,7 +315,7 @@ static int OpenAccess(vlc_object_t *object)
>          CloseCommon(sys);
>          return VLC_EGENERIC;
>      }
> -
> +	

idem


> From c90690d2618ccd20736f4de60504d10898622c5f Mon Sep 17 00:00:00 2001
> From: Kamil Klimek <naresh at tlen.pl>
> Date: Wed, 9 Jun 2010 13:37:51 +0200
> Subject: [PATCH 2/2] fixed typo

Should be squashed (git rebase -i origin/master)


-- 
Xtophe



More information about the vlc-devel mailing list