[vlc-devel] [PATCH] Do not link to ole32 when trying to build Qt4 module on OSX

Juho Vähä-Herttua juhovh at iki.fi
Wed Jun 16 19:44:38 CEST 2010


On 16.6.2010, at 20.36, Rémi Denis-Courmont wrote:
> On Wed, 16 Jun 2010 10:46:14 +0300, Juho Vähä-Herttua <juhovh at iki.fi>
> wrote:
>> The Qt4 detection in configure.ac wants to link to ole32 even when on
>> darwin, this patch should fix it.
> 
> This is backward in my opinion. ole32 should be linked on Windows only
> instead.

That's exactly what the patch does, ole32 is linked on "mingw32" and "mingwce", no additional libraries are linked on "darwin", all the rest are using X11. Of course can change != into == if it feels cleaner, but I wanted to use the same notation as the code before it. Should I modify the patch?


Juho




More information about the vlc-devel mailing list