[vlc-devel] [PATCH] fix a crash in live555 on stream close

[Sébastien Escudier]

Hi,

There is a bug in live555.cpp when the demuxer is closed.
teardownMediaSession may call StreamClose, but teardownMediaSession is called
after live_track_t is freed.
So we access invalid memory in StreamClose.

I can see two solutions (implemented in the patches attached) :
- We don't need to pass live_track_t to StreamClose. Instead we can pass
p_demux.
- We could first close live555 library and then delete the tracks.

Don't know which solution is better, so I send them both.

Regards,
Seb.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-a-crash-in-live555-demuxer-on-close_1.patch
Type: text/x-diff
Size: 2023 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100617/ce3a79c4/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-a-crash-in-live555-demuxer-on-close_2.patch
Type: text/x-diff
Size: 1740 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100617/ce3a79c4/attachment-0001.patch>