[vlc-devel] [vlc-commits] commit: Qt4: don' t do playlist_model recursive remove as core signals for those anyway ( Ilkka Ollakka )

[Jakob Leben]

On Fri, Jun 18, 2010 at 6:12 PM, Jakob Leben <jakob.leben at gmail.com> wrote:

> On Fri, Jun 18, 2010 at 2:35 PM, <git at videolan.org> wrote:
>
>> vlc | branch: master | Ilkka Ollakka <ileoo at videolan.org> | Fri Jun 18
>> 15:35:04 2010 +0300| [926bbf142f297f9715e3cc5ad746b98a448c3451] | committer:
>> Ilkka Ollakka
>>
>> Qt4: don't do playlist_model recursive remove as core signals for those
>> anyway
>>
>> + * Lets not worry about nodes children, we do refersh anyway when
>> + * core tells that playlist has changed, should give some more speed
>>
>
>

> Speed? I am sure it's faster that PLModel::recurseDelete() removes items to
> delete from the selected list, than making a route through the core back to
> Qt for every of those items (thus searching by ID at the core side and again
> back at the Qt side).
>


Plus, your commit makes more playlist lockings than before, so it is less
efficient in that sense as well.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100618/33ecfa4f/attachment.html>