[vlc-devel] [PATCH] gui/macosx: create a preferences file when first run.

[Rémi Denis-Courmont]

On Sunday 20 June 2010 16:35:50 Andre-John Mas, you wrote:
> On 16-Jun-2010, at 12:41, Jean-Baptiste Kempf wrote:
> > On Wed, Jun 16, 2010 at 01:19:12PM +0200, Dilaroga dev wrote :
> >> In attachment a patch that creates a preferences file at launch time
> >> when the vlcrc file doesn't exist yet.
> >> This patch closes #3684.
> > 
> > Is this really the right place to do it?
> > 
> > Souldn't this be fixed in the core?
> > What happens if you start vlc with -Irc the first time?
> 
> In this regards, we should be asking what level is currently responsible
> for creating the preferences file?

Saving the configuration should be avoided, unless the user explicitly asked 
for it. The Qt4 first run save has caused scores of issues in the past. 
Replicating that mistake is not a good idea.

The core will update the automatically saved configuration items at exit, if 
any of them were modified. The interface should save the configuration if and 
only if the user requested so (i.e. pressed the Save button).

> If it is the core then it should be there.

No.

> If on the other hand it is the higher level VLC application,

LibVLC applications are not supposed to use the configuration in the first 
place. This is really a VLC media player thing, and it is not even exposed in 
the current LibVLC API. It is not accident that "ignore-config" is true by 
default.

> then it should be there. Its a question of trying to keep things
> consistent.

-- 
Rémi Denis-Courmont