[vlc-devel] [PATCH] 1-of-3: vlc-1.1.0 network poll timeout

[Frank Enderle]

Hi,

I changed the patch to not modify net_Read. Instead I introduced a new
function net_Poll which just does the poll. http access calls now this
function before each net_Read to see if there's data. net_Read is then
only called if net_Poll does not return an error.

Is this acceptable?

Cheers,

Frank

Am 24.06.2010 02:07, schrieb Rémi Denis-Courmont:
> On Thursday 24 June 2010 01:38:38 Frank Enderle, you wrote:
>> Hi,
>>
>> I'd like to subit the following patch against the VLC-1.1.0 release.
> 
> This patch is semantically incorrect. We have code paths in VLC that expect 
> net_Read() to take whatever time it takes to get data. With this patch, it 
> will just fail.
> 
> Nack.
> 


-- 
Dipl.-Ing. (FH) Frank Enderle

anamica UG (haftungsbeschränkt)
Beinsteinerstr. 6
71334 Waiblingen

Telefon:  +49 151 14981091
Telefax:  +49 7151 1335770
E-Mail:   frank.enderle at anamica.de
Internet: www.anamica.de

Handelsregister: AG Stuttgart HRB 732357
Geschäftsführer: Yvonne Holzwarth, Frank Enderle
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: vlc-git-http-timeout.diff
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100624/50088a5a/attachment.ksh>