[vlc-devel] [PATCH] Disable faad, lower priority of decoder below avcodec

Rémi Denis-Courmont remi at remlab.net
Sat Jun 26 00:02:33 CEST 2010


On Fri, 25 Jun 2010 17:50:30 -0400, Alex Converse <alex.converse at gmail.com>
wrote:
>>> What features?
>>
>> Crashing randomly on not-perfect streams.
>>
>> Although, I have to say that the libmpeg2 decoding feels a bit sharper.
>> And a few other people noticed it too.
>> Still crashing way too much. There is a good reason that lavc has now
>> the priority.
>>
> 
> We know of this crasher: http://roundup.ffmpeg.org/issue1872

Uh? I think JB meant that libmpeg2 crashed more than ffmpeg, not the other
way around.

Now this is not at all news. Meuuh claimed a long time ago that libmpeg2
did not check for overflowing motion compensation vectors, as it would slow
down decoding.

In my opinion, it actually makes sense to not check for overflow, *if* you
run the decoder in its own isolated constrained process (with no access to
file system, tracing, network...), à la Chrome browser. Then you can
leverage the CPU memory protection as your boundary checks. But VLC does
not do process isolation at all, let alone constrained process isolation.

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis




More information about the vlc-devel mailing list