[vlc-devel] [PATCH] Disable faad, lower priority of decoder below avcodec

[Måns Rullgård]

Laurent Aimar <fenrir at elivagar.org> writes:

> On Fri, 2010-06-25 at 22:37 +0100, Måns Rullgård wrote:
>> Rémi Denis-Courmont <remi at remlab.net> writes:
>> 
>> > On Fri, 25 Jun 2010 21:36:23 +0200, Rafaël Carré <rafael.carre at gmail.com>
>> > wrote:
>> >> About libmpeg2 iirc fenrir said our decoder had features that ffmpeg
>> >> decoder hasn't.
>> >
>> > It does.
>> 
>> What features?
> - There was an issue with DVD menus. It is not a bug in avcodec but
> avcodec outputs the first I frame with a latency of one (unless there is
> an EOS). It is now OK in VLC as we insert an EOS when we detect a menu.
> - avcodec has decoding issues with field pictures at least on some
> samples I have (I only recently seen this issue while adding dxva2
> mpeg2).

Have you reported these problems?

>  Anyway, IMHO keeping both versions of a decoder even after their
> priority order has changed for the first release is a good thing. It
> allow to easily detect regressions due to the codec change and/or to
> have a quick workaround.

I'm not disagreeing with that.

-- 
Måns Rullgård
mans at mansr.com