[vlc-devel] [vlc-commits] commit: xspf: silently skip unknown extension nodes (fix #3696) ( Rémi Duraffort )

Rémi Duraffort ivoire at videolan.org
Mon Jun 28 18:12:28 CEST 2010


Le lundi 28 juin 2010 à 12:20:01, Rémi Denis-Courmont a écrit :
> On Sunday 27 June 2010 21:08:08 git at videolan.org, you wrote:
> > +            /* Skip all children */
> > +            while( xml_ReaderRead( p_xml_reader ) == 1 )
> > +            {
> > +                if( xml_ReaderNodeType( p_xml_reader ) ==
> > XML_READER_ENDELEM ) +                {
> > +                    char *psz_name = xml_ReaderName( p_xml_reader );
> > +                    if( !strcmp( psz_name, "extension" ) )
> 
> What if you have nested <extension> tags? I would assume libxml provides a 
> saner way to skip the content of a tag.
The code only skip the nested <extension ... /> tag. So no problem with
nested and non-nested tags.


Best regards

-- 
Rémi Duraffort | ivoire



More information about the vlc-devel mailing list