[vlc-devel] [vlc-commits] commit: skins2(Linux): check if _NET_WM_PID is supported (Erwan Tulou )
brezhoneg1 at yahoo.fr
Mon Jun 28 23:12:03 CEST 2010
On 28/06/2010 14:14, Rémi Denis-Courmont wrote:
> On Monday 28 June 2010 12:08:52 git at videolan.org, you wrote:
>> vlc | branch: master | Erwan Tulou<erwan10 at videolan.org> | Mon Jun 28
>> 10:13:03 2010 +0200| [ec30dbc12d48358711d25a5c80a509e641e6bb79] |
>> committer: Erwan Tulou
>> skins2(Linux): check if _NET_WM_PID is supported
> If the window manager is started after VLC, you won't define the PID anymore,
> which is wrong. And if there is no window manager, you couldn't care less that
> NET_WM_PID is defined but not supported.
Do you mean that something's wrong or could be done in a better way
in the patch ?
Actually, window managers must advertise which EWMH features they
support in _NET_SUPPORTED at the root window level.
For Ubuntu10.04, KDE4.4.2 does support _NET_WM_PID, but Gnome2.30
The result for Gnome users was a series of the following non fatal
(one per skins windows created):
X Error: BadAtom (invalid Atom parameter) 5
Major opcode: 18 (X_ChangeProperty)
Resource id: 0x0
The patch was just intended to remove these scary warnings by not
setting the property, since the WM didn't care.
Yet, what is the real use of _NET_WM_PID ? I don't know. (I guess
it gives a means to kill a unresponsive process). It was implemented
because the docky maintainers advised to do so. I'm wondering if third
party software (Docky is not part of the WM) can make use of this
feature even if it is not 'officially' supported by the underlying WM.
In which case, it would be better to create this property anyway .... Is
that what you suggested in your post ?
More information about the vlc-devel