[vlc-devel] ffmpeg rtsp access demuxer

[Rémi Denis-Courmont]

	Hello,

On Thursday 24 June 2010 11:23:15 Josh Allmann, you wrote:
> > +        strcpy(opts, "?tcp");
> > 
> > If I'm not mistaken, you could simply assign a const char pointer instead
> > of using strcpy().
> 
> Fixed
> 
> > +    else if( var_CreateGetBool( p_demux, "rtsp-http" ) )
> > +        strcpy(opts, "?http");
> > +    else if( var_CreateGetBool( p_demux, "rtsp-udp" ) )
> > +        strcpy(opts, "?udp");
> > 
> > Same notes as above.
> 
> Fixed

Now that I think of it, this is very much RTSP-specific. The current code 
should work (I haven't tried). But in the interest of extensibility, it might 
make sense to refactor the current
	DemuxOpen(vlc_object_t *)
into
	DemuxOpen(demux_t *, const char *path, bool is_opened)
and create two separate plugin entry points, one for the existing avformat 
demux plugin, and one for the new RTSP access_demux. Then it will be easier to 
add other protocols such as MMS out of avformat later and it looks cleaner 
(IMHO). Do I make sense?

-- 
Rémi Denis-Courmont