[vlc-devel] [vlc-commits] commit: Win32: try to fix atomic adds with InterlockedExchangeAdd iso InterlockedAdd ( Jean-Baptiste Kempf )

[Ilkka Ollakka]

On Tue, Jun 29, 2010 at 01:47:57AM +0200, git at videolan.org wrote:
> vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Tue Jun 29 01:47:21 2010 +0200| [bde1898a73522e268bbe43c6f5d4da27c4681a45] | committer: Jean-Baptiste Kempf 

> Win32: try to fix atomic adds with InterlockedExchangeAdd iso InterlockedAdd

>  {
>  #if defined (WIN64)
> -    return InterlockedAdd64 (&atom->s, v);
> +    return InterlockedExchangeAdd64 (&atom->s, v);
>  #else
> -    return InterlockedAdd (&atom->s, v);
> +    return InterlockedExchangeAdd (&atom->s, v);
>  #endif

Doesn't this return atom->s before add operation, so we should return
atom->s after that function?

-- 
Ilkka Ollakka
Nature is by and large to be found out of doors, a location where, it
cannot be argued, there are never enough comfortable chairs.
		-- Fran Leibowitz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100629/452eb04e/attachment.sig>