[vlc-devel] [PATCH] MKV : Fix access name check.

[Rémi Denis-Courmont]

On Tuesday 29 June 2010 19:59:40 Jai Menon, you wrote:
> ---
>  modules/demux/mkv/mkv.cpp |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/modules/demux/mkv/mkv.cpp b/modules/demux/mkv/mkv.cpp
> index b797feb..b1abec9 100644
> --- a/modules/demux/mkv/mkv.cpp
> +++ b/modules/demux/mkv/mkv.cpp
> @@ -141,7 +141,7 @@ static int Open( vlc_object_t * p_this )
>      if (var_InheritBool( p_demux, "mkv-preload-local-dir" ))
>      {
>          /* get the files from the same dir from the same family (based on
> p_demux->psz_path) */ -        if (p_demux->psz_path[0] != '\0' &&
> !strcmp(p_demux->psz_access, "")) +        if (p_demux->psz_path[0] !=
> '\0' && !strcmp(p_demux->psz_access, "file")) {
>              // assume it's a regular file
>              // get the directory path

It's a bit more complicated. We would need to convert psz_path from file:// URI 
to local path format. I guess there is a similar bug in the avformat plugin 
and in all file-capable access_demux plugins.

So I guess we need to change demux_t like I changed access_t a while ago: 
remove psz_path, add psz_location and psz_filepath.

-- 
Rémi Denis-Courmont