[vlc-devel] [PATCH] Qt: corrections of tree operations in playlist

Jakob Leben jakob.leben at gmail.com
Fri Mar 5 16:41:31 CET 2010


This patch fixes behavior of operations specific to tree structure
manipulations on playlist. I post it here for review, because it is rather
large and we are in feature freeze. I think however that it is a crucial fix
that might save a lot of bad mood to some users.

- When drag'n'dropping the list of selected items is sorted correctly
according to their position in tree. This keeps their relative order after
drop operation even if they originated from different parent nodes.
- If a parent and any of it's children are selected, only the parent enters
drag'n'drop operation. Children are thus not moved out of the parent after
the operation.
- Copying by drag and dropping performs a recursive copy, so if a parent is
copied, all it's children are as well.

I would also suggest to move the new PLModel::recursiveAppendCopy() function
to core playlist API. It is an operation that really belongs there and can
be useful later as well. ...if that is not a problem since we are in feature
freeze.

Please comment.

Best regards,
Jakob
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100305/1c20e701/attachment.html>


More information about the vlc-devel mailing list